Skip to content

fix freeze context only for capturing line probe #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpbempel merged 1 commit into from
Aug 29, 2024
Merged

fix freeze context only for capturing line probe #7456

jpbempel merged 1 commit into from
Aug 29, 2024

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Aug 16, 2024 •
edited by atlassian bot
Loading

What Does This Do

non-capturing line probe should not freeze line context because it is useless and too expensive (add overhead)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2698

@jpbempel
fix freeze context only for capturing line probe
b6be10b 
non-capturing line probe should not freeze line context because it
is useless and too expensive (add overhead)
@jpbempel jpbempel requested a review from a team as a code owner August 16, 2024 13:00
@jpbempel jpbempel requested review from shatzi and removed request for a team August 16, 2024 13:00
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug Bug report and fix labels Aug 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 16, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1723813739 1723814119
end_time 2024-08-16T13:10:13 2024-08-16T13:16:33
git_branch master jpbempel/fix-freeze-line-probe
git_commit_sha 529f893 b6be10b
start_time 2024-08-16T13:09:00 2024-08-16T13:15:20
See matching parameters
Baseline Candidate
ci_job_id 607151432 607151432
ci_pipeline_id 41973452 41973452
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1723813119 1723813119

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-34.948µs; +23.028µs] or [-13.234%; +8.720%]		 unstable
[-49.754µs; +35.235µs] or [-16.533%; +11.708%]		 unstable
[-61.138µs; +46.068µs] or [-19.464%; +14.666%]		 unstable
[-119.675µs; +83.140µs] or [-18.383%; +12.771%]		 same
scenario:basic same same same unstable
[-52.266µs; +41.033µs] or [-8.440%; +6.626%]		 unstable
[-149.794op/s; +149.794op/s] or [-5.842%; +5.842%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (300.945 µs) : 251, 351
.   : milestone, 301,
basic (302.93 µs) : 294, 312
.   : milestone, 303,
loop (10.535 ms) : 10507, 10563
.   : milestone, 10535,
section candidate
noprobe (293.685 µs) : 266, 321
.   : milestone, 294,
basic (300.976 µs) : 293, 309
.   : milestone, 301,
loop (10.552 ms) : 10510, 10594
.   : milestone, 10552,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 300.945 µs [250.72 µs, 351.17 µs]
basic 302.93 µs [293.825 µs, 312.034 µs]
loop 10.535 ms [10.507 ms, 10.563 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 293.685 µs [266.012 µs, 321.359 µs]
basic 300.976 µs [293.234 µs, 308.719 µs]
loop 10.552 ms [10.51 ms, 10.594 ms]

@pr-commenter
Copy link

pr-commenter bot commented Aug 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-freeze-line-probe
git_commit_date 1723811562 1723813119
git_commit_sha 529f893 b6be10b
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~b6be10b416
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723815406 1723815406
ci_job_id 607151426 607151426
ci_pipeline_id 41973452 41973452
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055686
Total [baseline] (10.464 s) : 0, 10463784
Agent [candidate] (1.049 s) : 0, 1049239
Total [candidate] (10.45 s) : 0, 10450396
section appsec
Agent [baseline] (1.167 s) : 0, 1167310
Total [baseline] (10.493 s) : 0, 10492632
Agent [candidate] (1.173 s) : 0, 1172708
Total [candidate] (10.504 s) : 0, 10504187
section iast
Agent [baseline] (1.191 s) : 0, 1191490
Total [baseline] (10.857 s) : 0, 10856510
Agent [candidate] (1.195 s) : 0, 1194685
Total [candidate] (10.904 s) : 0, 10904054
section profiling
Agent [baseline] (1.249 s) : 0, 1249070
Total [baseline] (10.75 s) : 0, 10749553
Agent [candidate] (1.248 s) : 0, 1247926
Total [candidate] (10.737 s) : 0, 10736924
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.167 s 111.624 ms (10.6%)
Agent iast 1.191 s 135.804 ms (12.9%)
Agent profiling 1.249 s 193.384 ms (18.3%)
Total tracing 10.464 s -
Total appsec 10.493 s 28.848 ms (0.3%)
Total iast 10.857 s 392.726 ms (3.8%)
Total profiling 10.75 s 285.768 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.173 s 123.47 ms (11.8%)
Agent iast 1.195 s 145.446 ms (13.9%)
Agent profiling 1.248 s 198.687 ms (18.9%)
Total tracing 10.45 s -
Total appsec 10.504 s 53.792 ms (0.5%)
Total iast 10.904 s 453.658 ms (4.3%)
Total profiling 10.737 s 286.528 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.357 ms) : 0, 673357
BytebuddyAgent [candidate] (669.124 ms) : 0, 669124
GlobalTracer [baseline] (309.015 ms) : 0, 309015
GlobalTracer [candidate] (307.147 ms) : 0, 307147
AppSec [baseline] (51.564 ms) : 0, 51564
AppSec [candidate] (51.327 ms) : 0, 51327
Remote Config [baseline] (688.771 µs) : 0, 689
Remote Config [candidate] (680.043 µs) : 0, 680
Telemetry [baseline] (7.576 ms) : 0, 7576
Telemetry [candidate] (7.52 ms) : 0, 7520
section appsec
BytebuddyAgent [baseline] (677.204 ms) : 0, 677204
BytebuddyAgent [candidate] (682.195 ms) : 0, 682195
GlobalTracer [baseline] (299.593 ms) : 0, 299593
GlobalTracer [candidate] (300.712 ms) : 0, 300712
AppSec [baseline] (157.304 ms) : 0, 157304
AppSec [candidate] (157.194 ms) : 0, 157194
Remote Config [baseline] (600.486 µs) : 0, 600
Remote Config [candidate] (602.141 µs) : 0, 602
Telemetry [baseline] (9.084 ms) : 0, 9084
Telemetry [candidate] (7.742 ms) : 0, 7742
IAST [baseline] (20.187 ms) : 0, 20187
IAST [candidate] (21.451 ms) : 0, 21451
section iast
BytebuddyAgent [baseline] (792.782 ms) : 0, 792782
BytebuddyAgent [candidate] (795.304 ms) : 0, 795304
GlobalTracer [baseline] (300.249 ms) : 0, 300249
GlobalTracer [candidate] (300.514 ms) : 0, 300514
AppSec [baseline] (50.549 ms) : 0, 50549
AppSec [candidate] (50.442 ms) : 0, 50442
Remote Config [baseline] (601.768 µs) : 0, 602
Remote Config [candidate] (605.377 µs) : 0, 605
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (11.196 ms) : 0, 11196
IAST [baseline] (24.92 ms) : 0, 24920
IAST [candidate] (22.929 ms) : 0, 22929
section profiling
ProfilingAgent [baseline] (95.591 ms) : 0, 95591
ProfilingAgent [candidate] (95.386 ms) : 0, 95386
BytebuddyAgent [baseline] (663.48 ms) : 0, 663480
BytebuddyAgent [candidate] (663.583 ms) : 0, 663583
GlobalTracer [baseline] (392.352 ms) : 0, 392352
GlobalTracer [candidate] (391.145 ms) : 0, 391145
AppSec [baseline] (52.375 ms) : 0, 52375
AppSec [candidate] (52.636 ms) : 0, 52636
Remote Config [baseline] (697.556 µs) : 0, 698
Remote Config [candidate] (693.709 µs) : 0, 694
Telemetry [baseline] (7.46 ms) : 0, 7460
Telemetry [candidate] (7.428 ms) : 0, 7428
Profiling [baseline] (95.615 ms) : 0, 95615
Profiling [candidate] (95.411 ms) : 0, 95411
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062299
Total [baseline] (8.558 s) : 0, 8558075
Agent [candidate] (1.048 s) : 0, 1047579
Total [candidate] (8.51 s) : 0, 8510137
section iast
Agent [baseline] (1.177 s) : 0, 1177293
Total [baseline] (9.002 s) : 0, 9002344
Agent [candidate] (1.178 s) : 0, 1178347
Total [candidate] (9.019 s) : 0, 9019481
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184910
Total [baseline] (8.981 s) : 0, 8980921
Agent [candidate] (1.176 s) : 0, 1176012
Total [candidate] (8.975 s) : 0, 8974617
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1189375
Total [baseline] (9.038 s) : 0, 9038468
Agent [candidate] (1.174 s) : 0, 1173969
Total [candidate] (8.994 s) : 0, 8993851
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.177 s 114.994 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 122.611 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.189 s 127.076 ms (12.0%)
Total tracing 8.558 s -
Total iast 9.002 s 444.269 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.981 s 422.846 ms (4.9%)
Total iast_TELEMETRY_OFF 9.038 s 480.394 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.178 s 130.768 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 128.433 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.174 s 126.39 ms (12.1%)
Total tracing 8.51 s -
Total iast 9.019 s 509.343 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 464.48 ms (5.5%)
Total iast_TELEMETRY_OFF 8.994 s 483.713 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.427 ms) : 0, 678427
BytebuddyAgent [candidate] (668.407 ms) : 0, 668407
GlobalTracer [baseline] (310.354 ms) : 0, 310354
GlobalTracer [candidate] (306.472 ms) : 0, 306472
AppSec [baseline] (51.609 ms) : 0, 51609
AppSec [candidate] (51.062 ms) : 0, 51062
Remote Config [baseline] (688.794 µs) : 0, 689
Remote Config [candidate] (683.584 µs) : 0, 684
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.492 ms) : 0, 7492
section iast
BytebuddyAgent [baseline] (783.897 ms) : 0, 783897
BytebuddyAgent [candidate] (784.208 ms) : 0, 784208
GlobalTracer [baseline] (296.748 ms) : 0, 296748
GlobalTracer [candidate] (296.386 ms) : 0, 296386
AppSec [baseline] (52.988 ms) : 0, 52988
AppSec [candidate] (53.258 ms) : 0, 53258
IAST [baseline] (21.601 ms) : 0, 21601
IAST [candidate] (23.274 ms) : 0, 23274
Remote Config [baseline] (574.445 µs) : 0, 574
Remote Config [candidate] (573.267 µs) : 0, 573
Telemetry [baseline] (7.992 ms) : 0, 7992
Telemetry [candidate] (7.166 ms) : 0, 7166
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.518 ms) : 0, 788518
BytebuddyAgent [candidate] (781.989 ms) : 0, 781989
GlobalTracer [baseline] (298.471 ms) : 0, 298471
GlobalTracer [candidate] (297.161 ms) : 0, 297161
AppSec [baseline] (49.672 ms) : 0, 49672
AppSec [candidate] (47.799 ms) : 0, 47799
IAST [baseline] (25.267 ms) : 0, 25267
IAST [candidate] (25.288 ms) : 0, 25288
Remote Config [baseline] (599.519 µs) : 0, 600
Remote Config [candidate] (578.732 µs) : 0, 579
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (9.68 ms) : 0, 9680
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.197 ms) : 0, 792197
BytebuddyAgent [candidate] (782.131 ms) : 0, 782131
GlobalTracer [baseline] (301.06 ms) : 0, 301060
GlobalTracer [candidate] (297.308 ms) : 0, 297308
AppSec [baseline] (54.091 ms) : 0, 54091
AppSec [candidate] (52.844 ms) : 0, 52844
IAST [baseline] (20.602 ms) : 0, 20602
IAST [candidate] (20.471 ms) : 0, 20471
Remote Config [baseline] (609.939 µs) : 0, 610
Remote Config [candidate] (604.718 µs) : 0, 605
Telemetry [baseline] (7.124 ms) : 0, 7124
Telemetry [candidate] (7.055 ms) : 0, 7055
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-16T13:09:26 2024-08-16T13:16:16
git_branch master jpbempel/fix-freeze-line-probe
git_commit_date 1723811562 1723813119
git_commit_sha 529f893 b6be10b
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~b6be10b416
start_time 2024-08-16T13:09:12 2024-08-16T13:16:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723814521 1723814521
ci_job_id 607151427 607151427
ci_pipeline_id 41973452 41973452
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1368
.   : milestone, 1348,
appsec (1.717 ms) : 1693, 1741
.   : milestone, 1717,
appsec_no_iast (1.733 ms) : 1709, 1758
.   : milestone, 1733,
iast (1.501 ms) : 1479, 1522
.   : milestone, 1501,
profiling (1.487 ms) : 1463, 1512
.   : milestone, 1487,
tracing (1.476 ms) : 1451, 1502
.   : milestone, 1476,
section candidate
no_agent (1.337 ms) : 1318, 1356
.   : milestone, 1337,
appsec (1.735 ms) : 1710, 1759
.   : milestone, 1735,
appsec_no_iast (1.725 ms) : 1701, 1749
.   : milestone, 1725,
iast (1.476 ms) : 1454, 1498
.   : milestone, 1476,
profiling (1.505 ms) : 1479, 1531
.   : milestone, 1505,
tracing (1.436 ms) : 1411, 1460
.   : milestone, 1436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.368 ms] -
appsec 1.717 ms [1.693 ms, 1.741 ms] 369.041 µs (27.4%)
appsec_no_iast 1.733 ms [1.709 ms, 1.758 ms] 385.59 µs (28.6%)
iast 1.501 ms [1.479 ms, 1.522 ms] 152.697 µs (11.3%)
profiling 1.487 ms [1.463 ms, 1.512 ms] 139.592 µs (10.4%)
tracing 1.476 ms [1.451 ms, 1.502 ms] 128.523 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.356 ms] -
appsec 1.735 ms [1.71 ms, 1.759 ms] 397.903 µs (29.8%)
appsec_no_iast 1.725 ms [1.701 ms, 1.749 ms] 387.942 µs (29.0%)
iast 1.476 ms [1.454 ms, 1.498 ms] 139.079 µs (10.4%)
profiling 1.505 ms [1.479 ms, 1.531 ms] 167.783 µs (12.6%)
tracing 1.436 ms [1.411 ms, 1.46 ms] 98.664 µs (7.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.614 µs) : 357, 398
.   : milestone, 378,
iast (488.293 µs) : 466, 510
.   : milestone, 488,
iast_FULL (550.975 µs) : 529, 573
.   : milestone, 551,
iast_GLOBAL (516.639 µs) : 492, 541
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (480.433 µs) : 460, 501
.   : milestone, 480,
iast_INACTIVE (465.38 µs) : 441, 490
.   : milestone, 465,
iast_TELEMETRY_OFF (476.929 µs) : 455, 498
.   : milestone, 477,
tracing (443.494 µs) : 423, 464
.   : milestone, 443,
section candidate
no_agent (374.735 µs) : 353, 396
.   : milestone, 375,
iast (483.954 µs) : 463, 505
.   : milestone, 484,
iast_FULL (557.547 µs) : 535, 580
.   : milestone, 558,
iast_GLOBAL (517.809 µs) : 495, 541
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (481.499 µs) : 460, 503
.   : milestone, 481,
iast_INACTIVE (461.303 µs) : 439, 484
.   : milestone, 461,
iast_TELEMETRY_OFF (474.493 µs) : 453, 496
.   : milestone, 474,
tracing (440.73 µs) : 421, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.614 µs [357.42 µs, 397.807 µs] -
iast 488.293 µs [466.47 µs, 510.117 µs] 110.68 µs (29.3%)
iast_FULL 550.975 µs [528.534 µs, 573.416 µs] 173.361 µs (45.9%)
iast_GLOBAL 516.639 µs [492.33 µs, 540.949 µs] 139.026 µs (36.8%)
iast_HARDCODED_SECRET_DISABLED 480.433 µs [459.539 µs, 501.326 µs] 102.819 µs (27.2%)
iast_INACTIVE 465.38 µs [440.78 µs, 489.981 µs] 87.767 µs (23.2%)
iast_TELEMETRY_OFF 476.929 µs [455.454 µs, 498.404 µs] 99.315 µs (26.3%)
tracing 443.494 µs [423.28 µs, 463.708 µs] 65.88 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.735 µs [353.371 µs, 396.099 µs] -
iast 483.954 µs [462.94 µs, 504.967 µs] 109.218 µs (29.1%)
iast_FULL 557.547 µs [535.054 µs, 580.04 µs] 182.812 µs (48.8%)
iast_GLOBAL 517.809 µs [494.653 µs, 540.965 µs] 143.074 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 481.499 µs [460.49 µs, 502.508 µs] 106.764 µs (28.5%)
iast_INACTIVE 461.303 µs [438.85 µs, 483.756 µs] 86.568 µs (23.1%)
iast_TELEMETRY_OFF 474.493 µs [453.39 µs, 495.597 µs] 99.758 µs (26.6%)
tracing 440.73 µs [420.739 µs, 460.721 µs] 65.995 µs (17.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-freeze-line-probe
git_commit_date 1723811562 1723813119
git_commit_sha 529f893 b6be10b
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~b6be10b416
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723815015 1723815015
ci_job_id 607151428 607151428
ci_pipeline_id 41973452 41973452
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.212 ms) : 2177, 2247
.   : milestone, 2212,
iast (1.967 ms) : 1925, 2009
.   : milestone, 1967,
iast_GLOBAL (2.019 ms) : 1976, 2061
.   : milestone, 2019,
profiling (1.872 ms) : 1838, 1907
.   : milestone, 1872,
tracing (1.843 ms) : 1810, 1876
.   : milestone, 1843,
section candidate
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.223 ms) : 2188, 2258
.   : milestone, 2223,
iast (1.966 ms) : 1925, 2007
.   : milestone, 1966,
iast_GLOBAL (2.024 ms) : 1981, 2067
.   : milestone, 2024,
profiling (1.856 ms) : 1823, 1890
.   : milestone, 1856,
tracing (1.835 ms) : 1802, 1867
.   : milestone, 1835,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.212 ms [2.177 ms, 2.247 ms] 745.973 µs (50.9%)
iast 1.967 ms [1.925 ms, 2.009 ms] 500.858 µs (34.2%)
iast_GLOBAL 2.019 ms [1.976 ms, 2.061 ms] 552.971 µs (37.7%)
profiling 1.872 ms [1.838 ms, 1.907 ms] 406.365 µs (27.7%)
tracing 1.843 ms [1.81 ms, 1.876 ms] 377.529 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.223 ms [2.188 ms, 2.258 ms] 767.028 µs (52.7%)
iast 1.966 ms [1.925 ms, 2.007 ms] 510.378 µs (35.1%)
iast_GLOBAL 2.024 ms [1.981 ms, 2.067 ms] 568.359 µs (39.0%)
profiling 1.856 ms [1.823 ms, 1.89 ms] 400.796 µs (27.5%)
tracing 1.835 ms [1.802 ms, 1.867 ms] 379.089 µs (26.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b6be10b416, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.819 s) : 18819000, 18819000
.   : milestone, 18819000,
iast_GLOBAL (17.718 s) : 17718000, 17718000
.   : milestone, 17718000,
profiling (15.688 s) : 15688000, 15688000
.   : milestone, 15688000,
tracing (15.078 s) : 15078000, 15078000
.   : milestone, 15078000,
section candidate
no_agent (14.93 s) : 14930000, 14930000
.   : milestone, 14930000,
appsec (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
iast (18.765 s) : 18765000, 18765000
.   : milestone, 18765000,
iast_GLOBAL (17.735 s) : 17735000, 17735000
.   : milestone, 17735000,
profiling (15.706 s) : 15706000, 15706000
.   : milestone, 15706000,
tracing (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.018 s [15.018 s, 15.018 s] -
appsec 14.998 s [14.998 s, 14.998 s] -20.0 ms (-0.1%)
iast 18.819 s [18.819 s, 18.819 s] 3.801 s (25.3%)
iast_GLOBAL 17.718 s [17.718 s, 17.718 s] 2.7 s (18.0%)
profiling 15.688 s [15.688 s, 15.688 s] 670.0 ms (4.5%)
tracing 15.078 s [15.078 s, 15.078 s] 60.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.93 s [14.93 s, 14.93 s] -
appsec 14.991 s [14.991 s, 14.991 s] 61.0 ms (0.4%)
iast 18.765 s [18.765 s, 18.765 s] 3.835 s (25.7%)
iast_GLOBAL 17.735 s [17.735 s, 17.735 s] 2.805 s (18.8%)
profiling 15.706 s [15.706 s, 15.706 s] 776.0 ms (5.2%)
tracing 15.024 s [15.024 s, 15.024 s] 94.0 ms (0.6%)

@jpbempel jpbempel merged commit 94bf2dd into master Aug 29, 2024
@jpbempel jpbempel deleted the jpbempel/fix-freeze-line-probe branch August 29, 2024 15:13
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanchooly evanchooly evanchooly approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @evanchooly